Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable enableUnifiedSyncLane for React Native (Meta) #29052

Merged
merged 1 commit into from
May 14, 2024
Merged

Enable enableUnifiedSyncLane for React Native (Meta) #29052

merged 1 commit into from
May 14, 2024

Conversation

yungsters
Copy link
Contributor

Summary

Enables the enableUnifiedSyncLane feature flag for React Native (Meta).

How did you test this change?

$ yarn test
$ yarn flow fabric

@react-sizebot
Copy link

Comparing: 9d76c95...31c7634

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 495.02 kB 495.02 kB = 88.68 kB 88.68 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 499.81 kB 499.81 kB = 89.36 kB 89.36 kB
facebook-www/ReactDOM-prod.classic.js = 592.16 kB 592.16 kB = 104.15 kB 104.15 kB
facebook-www/ReactDOM-prod.modern.js = 568.39 kB 568.39 kB = 100.55 kB 100.55 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 31c7634

rickhanlonii
rickhanlonii approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@yungsters yungsters merged commit 5f28f51 into facebook:main May 14, 2024
38 checks passed
@yungsters yungsters deleted the rn-flags branch May 14, 2024 05:56
github-actions bot pushed a commit that referenced this pull request May 14, 2024
@yungsters
Enable enableUnifiedSyncLane for React Native (Meta) (#29052)
7c948d3 
## Summary

Enables the `enableUnifiedSyncLane` feature flag for React Native
(Meta).

## How did you test this change?

```
$ yarn test
$ yarn flow fabric
```

DiffTrain build for commit 5f28f51.
@eps1lon eps1lon mentioned this pull request May 16, 2024
Merged
@jackpope jackpope mentioned this pull request Jun 24, 2024
Merged
jackpope added a commit that referenced this pull request Jun 24, 2024
@jackpope
Clean up enableUnifiedSyncLane flag (#30062)
c21bcd6 
`enableUnifiedSyncLane` now passes everywhere. Let's clean it up

Implemented with #27646

Flag enabled with #27646,
#28269,
#29052
github-actions bot pushed a commit that referenced this pull request Jun 24, 2024
@jackpope
Clean up enableUnifiedSyncLane flag (#30062)
ae90e9f 
`enableUnifiedSyncLane` now passes everywhere. Let's clean it up

Implemented with #27646

Flag enabled with #27646,
#28269,
#29052

DiffTrain build for [c21bcd6](c21bcd6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yungsters @react-sizebot @rickhanlonii @facebook-github-bot